Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Docgen lib maintenance #8896

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Addon-docs: Docgen lib maintenance #8896

merged 2 commits into from
Nov 20, 2019

Conversation

patricklafrance
Copy link
Member

Issue:

What I did

  • Flow not filter out "null" and "undefined" default values
  • Reworked the docgen lib utils to prepare for re-use
  • Added more test cases for prop types from an external file

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Nov 20, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/1ri6qg4z2
🌍 Preview: https://monorepo-git-docgen-lib-maintenance.storybook.now.sh

@patricklafrance patricklafrance added addon: docs maintenance User-facing maintenance tasks labels Nov 20, 2019
shilman
shilman approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title Docgen lib maintenance Addon-docs: Docgen lib maintenance Nov 20, 2019
@patricklafrance patricklafrance merged commit 4da8cf4 into next Nov 20, 2019
@shilman shilman added this to the 5.3.0 milestone Nov 20, 2019
@shilman shilman deleted the docgen-lib-maintenance branch November 20, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@patricklafrance @shilman